DKP Log Parser Forum Index
 Forum FAQ   Search   Register   Log in 
 About   Download   Forum   Wiki   Development
Allow ignoring raids without a reward

 
This forum is locked: you cannot post, reply to, or edit topics.   This topic is locked: you cannot edit posts or make replies.    DKP Log Parser Forum Index -> Suggestions - Completed

Author

Message

Lokorin
Site Admin


Joined: 03 Apr 2006
Posts: 697

PostPosted: Sun May 14, 2006 10:10 am    Post subject: Allow ignoring raids without a reward

Reply with quote


Status: Included in version 1.4.0

Problem
Currently all intervals have to be uploaded, even if they do not contain any reward. This is good for getting a better view of the participation, but can sometimes be unnecessary.

Suggestion
Add an option in the Server configuration tab named something like "Ignore intervals without rewards" in the form of a checkbox. Checking the checkbox should make it so that intervals with a total reward equal to 0 are ignored upon uploading the day to the server.

Things to consider
An analogous "Ignore events without rewards" option should probably also be included for completeness sake.

How the code should be modified
Simply modify the uploadIntervalsAsIndividualRaids, uploadIntervalsAsRaidBatch and uploadEvents methods in the Server class so that they filter the intervals and events prior to beginning the upload. The two methods for uploading raids should be refactored to avoid duplicated code.


Last edited by Lokorin on Wed Aug 23, 2006 3:53 pm; edited 1 time in total

Back to top

Lokorin
Site Admin


Joined: 03 Apr 2006
Posts: 697

PostPosted: Sun Jul 02, 2006 10:56 am    Post subject:

Reply with quote


An "Ignore loot items without price" option should probably also be added.

Back to top

Display posts from previous:   
This forum is locked: you cannot post, reply to, or edit topics.   This topic is locked: you cannot edit posts or make replies.    DKP Log Parser Forum Index -> Suggestions - Completed All times are GMT
Page 1 of 1

 


Powered by phpBB © 2001, 2005 phpBB Group
SoftGreen 1.1 phpBB theme © DaTutorials.com 2005