DKP Log Parser Forum Index
 Forum FAQ   Search   Register   Log in 
 About   Download   Forum   Wiki   Development
Participation + Reward Interval Problem

 
This forum is locked: you cannot post, reply to, or edit topics.   This topic is locked: you cannot edit posts or make replies.    DKP Log Parser Forum Index -> Error reports

Author

Message

Hundred



Joined: 15 Nov 2006
Posts: 7

PostPosted: Wed Nov 15, 2006 6:42 pm    Post subject: Participation + Reward Interval Problem

Reply with quote

Thank you for the great software, it has been a life saver. I really appreciate it.


I am having a problem with the parsing of some of my raids and I'm not sure what I'm doing wrong.

After I parse the string I'm correcting small gaps in the players' attendance in the Suspected Error window with "Correct All" defaulted to "Fill the gap".

The problem I'm having is that after doing this occasionally one player will be missing in a Reward Interval despite having perfect Participation Interval attendance.


My assumption is that a player will be accorded as present for a Reward Interval if they are present for all corresponding Participation Intervals.



I'm using 1.4.0e Windows

Preferences -> Parsing -> Settings
Default reward interval padding (seconds): 60
Reward interval padding (from first interval): 120

Preferences -> Program -> Suspected Errors
Display participation gap errors: On
Default way to correct participation gap errors: Fill the Gap
Maximum participation gap size (minutes): 30



Steps to recreate:
1) Parse string.
2) Correct All / Fill the gap.
3) Check player "Souijuro" under Participation, he is marked as present for every interval.
4) Check player "Souijuro" under "Reward Interval Participation", he is missing from reward interval 6.



Any assistance would be greatly appreciated.

conf.xml
 Description:

Download
 Filename:  conf.xml
 Filesize:  9.92 KB
 Downloaded:  129 Time(s)
string.txt
 Description:

Download
 Filename:  string.txt
 Filesize:  18.65 KB
 Downloaded:  127 Time(s)

Back to top

Lokorin
Site Admin


Joined: 03 Apr 2006
Posts: 697

PostPosted: Fri Nov 17, 2006 10:31 am    Post subject:

Reply with quote

First of all: Thank you for an excellent error report, it made it a lot easier to reproduce the problem.

It is indeed a serious bug. It has been entered as defect DLPC60. Expect a patch in a few hours.

Back to top

Lokorin
Site Admin


Joined: 03 Apr 2006
Posts: 697

PostPosted: Fri Nov 17, 2006 11:56 am    Post subject:

Reply with quote

Patch 1.4.0f has been released. It can be applied via "Miscellaneous -> Search for updates" in the menu.

Back to top

Hundred



Joined: 15 Nov 2006
Posts: 7

PostPosted: Fri Nov 17, 2006 12:57 pm    Post subject:

Reply with quote

Thanks Lorokin. You're a champ. Smile

Works great. Smile

Back to top

Hundred



Joined: 15 Nov 2006
Posts: 7

PostPosted: Tue Jul 31, 2007 6:45 pm    Post subject:

Reply with quote

Hi Lorokin. Smile

I'm not sure, but I think I may actually be encountering a similar bug.


I seem to be having the same core issue. No matter how I change the Participation for player "Raylen" I cannot get his Reward Interval Participation to update in some intervals.

Using 1.4.1 Windows.

Steps to Reproduce:
1) Parse string. Select 25th of July.
2) Correct All x 3.
3) Add Raylen to all Participation intervals by highlighting them all and using "Add".
4) Check Participation for Raylen, he is present for all.
4) Check Reward Interval Participation for Raylen. Segments 11 and 13 fail to acknowledge him.


Again, I am operating under the assumption that if a player is present for every Participation interval they will be marked present for every Reward Interval.

Any assistance you can render would be very much appreciated.

conf.xml
 Description:
conf.xml

Download
 Filename:  conf.xml
 Filesize:  8.35 KB
 Downloaded:  117 Time(s)
parse.txt
 Description:
DKP String

Download
 Filename:  parse.txt
 Filesize:  63.77 KB
 Downloaded:  130 Time(s)

Back to top

Lokorin
Site Admin


Joined: 03 Apr 2006
Posts: 697

PostPosted: Sun Aug 05, 2007 11:37 am    Post subject:

Reply with quote

Hundred wrote:
I seem to be having the same core issue. No matter how I change the Participation for player "Raylen" I cannot get his Reward Interval Participation to update in some intervals.


Thanks for the error report.

I have reproduced this and it does look like a bug. It has been filed as DLPC72 and a fix will hopefully be around soon.

Back to top

Lokorin
Site Admin


Joined: 03 Apr 2006
Posts: 697

PostPosted: Wed Aug 08, 2007 8:42 pm    Post subject:

Reply with quote

Update: The bug has been fixed in the source repository. I want to include a couple of low priority fixes in the same release though, so I would not expect a released patch before the weekend (I'm assuming that releasing the patch is not that urgent).

Back to top

Hundred



Joined: 15 Nov 2006
Posts: 7

PostPosted: Thu Aug 09, 2007 4:58 am    Post subject:

Reply with quote

Lokorin wrote:
Update: The bug has been fixed in the source repository. I want to include a couple of low priority fixes in the same release though, so I would not expect a released patch before the weekend (I'm assuming that releasing the patch is not that urgent).


Thanks a million. Smile It's not urgent for me personally, I'm triple checking everything and just fixing up the raid in EQDKP afterwards when someone is left out of a segment.

Out of interest, is there any notes/comments/etc relating to the bug fixing process beyond the brief summary in Scarab? I had a look to see if I might be able to play with it (since it's seems you're pretty busy these days Smile) and was hoping there was at least a clue in the bug report to point me in the right direction. Wink

Back to top

Lokorin
Site Admin


Joined: 03 Apr 2006
Posts: 697

PostPosted: Thu Aug 09, 2007 9:08 pm    Post subject:

Reply with quote

Hundred wrote:
Out of interest, is there any notes/comments/etc relating to the bug fixing process beyond the brief summary in Scarab? I had a look to see if I might be able to play with it (since it's seems you're pretty busy these days Smile) and was hoping there was at least a clue in the bug report to point me in the right direction. Wink


I'm not sure if I follow, what kind of clue are you looking for? A workaround for the problem or how to fix the bug in the source?

If you want the former then the workaround is to not have participation intervals that entirely contain a reward interval (i.e. not have a reward interval that starts and ends inside the same participation interval).

If you want the latter then you can check out the source from the project's subversion repository located at svn://dkplp.org (you need a subversion client to access it). The fix was submitted as r1163 (as noted in the scarab history), the cutting edge source is located in /branches/client/1.4.1 . If you want more specific information about how to build it then feel free to ask and I will explain the build process.

A long standing goal of mine is to move everything to sourceforge and/or replace scarab with trac to make it easier to get insight and hopefully attract someone who wants to continue the development.

Back to top

Hundred



Joined: 15 Nov 2006
Posts: 7

PostPosted: Fri Aug 10, 2007 3:27 am    Post subject:

Reply with quote

I was looking for a clue as to the cause of the problem in your bug documentation to see if I could patch it myself, but I guess there's no real point to you documenting bugs in detail in Scarab when you're the only one involved in the development.

I can't imagine doing time based DKP without this tool, thanks for taking the time to fix this little bug for us.

Back to top

Lokorin
Site Admin


Joined: 03 Apr 2006
Posts: 697

PostPosted: Fri Aug 10, 2007 8:46 am    Post subject:

Reply with quote

Hundred wrote:
I was looking for a clue as to the cause of the problem in your bug documentation to see if I could patch it myself, but I guess there's no real point to you documenting bugs in detail in Scarab when you're the only one involved in the development.


I'm not sure what more I could have documented in scarab without duplicating the contents of the changes. It sounds like you're looking for the diff though, so I have attached it.

r1163.diff
 Description:

Download
 Filename:  r1163.diff
 Filesize:  1.18 KB
 Downloaded:  90 Time(s)

Back to top

Hundred



Joined: 15 Nov 2006
Posts: 7

PostPosted: Sat Aug 11, 2007 1:40 am    Post subject:

Reply with quote

Ah sorry Lorokin, I just meant I was looking for more info initially on the 5th of August when you acknowledged the bug. Obviously there's much more in Scarab now and it's all kind of moot anyway since you fixed it. I'll leave you alone now. Smile

Back to top

Lokorin
Site Admin


Joined: 03 Apr 2006
Posts: 697

PostPosted: Sun Aug 12, 2007 5:24 pm    Post subject:

Reply with quote

Version 1.4.1a has been uploaded containing a fix for this and another bug.

I have taken the patch server down though due to some problems resulting from the server switch, so you will have to manually download and replace for the time being.

Back to top

Hundred



Joined: 15 Nov 2006
Posts: 7

PostPosted: Thu Aug 16, 2007 6:37 am    Post subject:

Reply with quote

Thanks Lokorin. It's much appreciated.


EDIT: For some reason most of the dkplp.org site is returning empty pages to me, but it might just be something at my end. I was still able to download the new version by manually constructing a link.
http://dkplp.org/download/latest/dkp-log-parser-1.4.1a-win32.zip

Back to top

Display posts from previous:   
This forum is locked: you cannot post, reply to, or edit topics.   This topic is locked: you cannot edit posts or make replies.    DKP Log Parser Forum Index -> Error reports All times are GMT
Page 1 of 1

 


Powered by phpBB © 2001, 2005 phpBB Group
SoftGreen 1.1 phpBB theme © DaTutorials.com 2005