 |
|
 |
|
|
Author |
Message |
Lokorin
Site Admin
Joined: 03 Apr 2006
Posts: 697
|
 Posted: Tue Jun 27, 2006 7:32 pm Post subject: Testing version 1.4.0 - alpha |
|
|
An alpha test of the coming version 1.4.0 has been released. Please use this thread to post any problems found, questions about the new version and suggestions for minor modifications.
Before posting a bug please check the list of known problems. If it is not in there then please add it.
*edit*
See the related news entry for more information.
Changelog (unchecked):
| Code: |
* Updated the EQ2 predefined pattern set for /whoraid, apparently the command was recently changed. Please inform me if it changes again.
* Changed all existing Loot patterns for the EQ and EQ2 predefined sets so that they all have to begin with "*Loot" making them similar to every other command that DKP Log Parser provides. This is done for two reasons, first and foremost to eliminate the anomaly and make the commands more consistent, but also to avoid other lines to mistakenly be interpreted by the parser as loot.
* All loot patterns in the predefined sets now accept negative prices and prices with decimals in them.
* The "Server" configuration tab has been split into two tabs: "Server" and "Uploads", the latter handeling everything that has to do with uploading things to the server.
* Added two new options for ignoring intervals and/or events with a reward equal to 0 when uploading a day to the server. The new options can be found in the "Uploads" configuration tab. Intervals with loot are never ignored.
* Lots of options in the configuration dialog have been renamed, more on that later.
* Added a new error type that gaps in the participation.
* The loot items can now be modified directly through the loot table by editing the cells.
* The loot table will no longer scroll to the top after a modification has been made.
* The GUI's tables will now do a better job of avoiding unnecessary repaints when they are updated (meaning they GUI will update faster).
* Changes to the sizes of the different GUI parts are now properly saved. So if a part is resized then it stays at that size even after restarting the program. Previously the size was only saved when closing the program through the menu.
* Major reorganisation of the GUI.
** Bundled the small parts.
** Split the participation into reward interval participation, event participation and an additional table in the Global tab.
** The table in the global tab now displays more information, such as the total percentage of time spent in the raid.
** The new complete participation tabs allow the participation to be altered.
** Shortcuts to all the intervals in the complete participation has been added to the bottom.
* The zone name for reward intervals are now set in the reward interval table.
* Added a checkbox for setting the "Check for new versions on startup" in the configuration wizard.
* Renamed the predefined pattern sets for WoW. They now list the oldformat setting instead of the version number.
* Added an option for setting the way that the global bonus is distributed. It can be set to distribute per interval, per minute or disabled.
* Added an option for setting the reward system that should be used. There are currently three settings: time-based, event-based and a hybrid of the two.
* The various checkboxes for uploading reward intervals and events in different ways to the server have now been turned into two comboboxes in which one can choose the representation for the two.
* Added support for using remote preprocessors. This allows the parser to handle logs that it normally can not handle such as for instance Ventrilo logs. The preprocessors reside on servers and anyone can write one as long as it satisfies a specified XML-RPC interface. An official server with preprocessors will be provided along with the source, but anyone can set one up and make their own modifications to the existing processors or make new ones.
* The configuration and member aliases can now be exported and later exported. This allows people to share configuration more easily and to switch between multiple setups.
* Two new pattern sets have been added for EQ and EQ2 that treat each log taken (with /who and /whoraid repectivly) as an event. This means that a DKP reward can be assigned to everyone present in each indiviudal log. The new pattern sets are event-based, i.e. do not contain any time-based aspect.
* Added a new operator '@' to the XML pattern format. It is used to separate multiple patterns that should all trigger a capture. So one can now for instance make event patterns that trigger on both boss kills and specific item drops.
* The options in the "upload" tab in the configuration have been changed a bit, the representations for each major aspect of a day can now be choosen via dropdowns instead of checkboxes. Note that these will not display any representations if the EQDKP plugin version 1.3.1c or earlier is used. In those cases a raid representation is used.
|
Last edited by Lokorin on Sun Jul 16, 2006 8:50 am; edited 2 times in total |
|
Back to top |
|
 |
impishfae
Joined: 19 Jun 2006
Posts: 125
Location: Australia
|
| Posted: Thu Jun 29, 2006 7:52 am Post subject: |
|
|
Testing of Doom! 
DKPLP 1.4.0 alpha
EQDKP plugin 1.3.1b
Issues with default GUI layout.
Parts of the 'Complete Participation' panel are hidden underneath the participation shortcuts area.
'Participation shortcuts' should probably bind to the bottom of the frame, pulling down everything with it.
'Global' tab: the Reward column only has one decimal place, but most places in the program indicate there's two decimal places of precision: it'd be good if the Reward column had two decimal places too.
Status bar. Can this go red if there's a suspected error? I like red!  (either red text over 'Suspected Errors: X' or red background for the whole bar)
After highlighting a loot line to edit its values (don't suppose you want to allow people to edit an existing line in-place, similarly to the 'reward intervals' layout?), I edit, I hit done. The line still remains partially visually highlighted, though the program doesn't think there's anything selected. (Edit button reports 'no item selected'). Not 100% reproducible. Possibly related to single-clicking, rather than double-clicking, or trying to select a line by clicking on a column other than the 'Time' one.
I've lost the mechanism to set the raid name? (I used to use the 'Global Raid Names' option, set the raid name on the first log and life would be good. Now it seems that I need to set the raid name on every interval, using the Reward Intervals panel?)
Default weights at 0 means no DKP assigned
When loading up my log file, and checking the global tab, I saw that no member had received DKP. It appears that the default weight per interval is now 0, not 1. Not sure if this was deliberate. (There didn't seem to be a config option for setting the default weight across all intervals)
Empty dropdowns in 'Uploads' configuration tab
The 'Day', 'Reward interval', 'Event' and 'Loot' representation dropdowns are empty if you're running with a DKPLP plugin older than 1.3.2
Can we get an error or warning on connection to the plugin from the client if the expected-actual versions are incompatible, and some sort of 'EQDKP plugin does not support this functionality' message in the 'Uploads' tab dropdowns. It also would be worthwhile putting a note in Help/About explaining what plugin version it requires to function properly, and what plugin version it found on last connection.
Entering loot prices assumes values under 1 by default.
If I enter '30' as my loot price, it reformats it to be 0.30. I need to enter '30.0' for it to enter in as I expect. I think I've seen other data entry areas behave this way too (default DKP reward per minute)
'Split' button doesn't seem to do anything?
'Join with next/previous' crashes program
Loaded up a raid log. I needed to remove the first log checkpoint as it was earlier in the day and spurious to the raid data. Not seeing a delete button, I tried the 'join with next' button, which crashed the program. Reloaded, selected the second log and tried 'join with previous', which also crashed the program. The error file reports in both instances:
| Code: |
java.lang.NullPointerException
at com.lokorin.dkplp.gui.GUI.updateTblGlobalRewards(Unknown Source)
at com.lokorin.dkplp.gui.GUI.access$1400(Unknown Source)
at com.lokorin.dkplp.gui.GUI$5.run(Unknown Source)
at org.eclipse.swt.widgets.Synchronizer.syncExec(Synchronizer.java:152)
at org.eclipse.swt.widgets.Display.syncExec(Display.java:3458)
at com.lokorin.dkplp.gui.GUI.update(Unknown Source)
at java.util.Observable.notifyObservers(Unknown Source)
at com.lokorin.dkplp.DayBlock.doDkpUpdateNotify(Unknown Source)
at com.lokorin.dkplp.DayBlock.calculateTimeDkp(Unknown Source)
at com.lokorin.dkplp.DayBlock.update(Unknown Source)
at java.util.Observable.notifyObservers(Unknown Source)
at com.lokorin.dkplp.RewardInterval.doNotifyObservers(Unknown Source)
at com.lokorin.dkplp.RewardInterval.updateParticipation(Unknown Source)
at com.lokorin.dkplp.RewardInterval.update(Unknown Source)
at java.util.Observable.notifyObservers(Unknown Source)
at com.lokorin.dkplp.DayParticipation.doUpdateNotify(Unknown Source)
at com.lokorin.dkplp.DayParticipation.join(Unknown Source)
at com.lokorin.dkplp.gui.GUI$ParticipationIntervalTab$2.widgetSelected(Unknown Source)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:90)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:843)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3125)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2758)
at com.lokorin.dkplp.gui.GUI.open(Unknown Source)
at com.lokorin.dkplp.gui.GUI.main(Unknown Source)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at com.lokorin.dkplp.gui.SplashWindow.invokeMain(Unknown Source)
at com.lokorin.dkplp.gui.Splasher.main(Unknown Source) |
|
|
Back to top |
|
|
Lokorin
Site Admin
Joined: 03 Apr 2006
Posts: 697
|
| Posted: Thu Jun 29, 2006 12:25 pm Post subject: |
|
|
| impishfae wrote: |
| Testing of Doom! |
Thank you for the list, they have been entered into the list of known problems. Below are some comments to the most interesting problems.
| Quote: |
| 'Global' tab: the Reward column only has one decimal place, but most places in the program indicate there's two decimal places of precision: it'd be good if the Reward column had two decimal places too. |
The number of decimals used around in the program can actually be set via some option, I forgot to vary the column size accordingly.
| Quote: |
| After highlighting a loot line to edit its values (don't suppose you want to allow people to edit an existing line in-place, similarly to the 'reward intervals' layout?), I edit, I hit done. The line still remains partially visually highlighted, though the program doesn't think there's anything selected. (Edit button reports 'no item selected'). Not 100% reproducible. Possibly related to single-clicking, rather than double-clicking, or trying to select a line by clicking on a column other than the 'Time' one. |
Actually it was supposed to be editeble like the reward intervals, I guess that is a problem too I remember someone telling me that the time column is the only clickable column in the loot table in win32, it is not like that on linux though. I'm not sure why it's like that.
| Quote: |
| If I enter '30' as my loot price, it reformats it to be 0.30. I need to enter '30.0' for it to enter in as I expect. I think I've seen other data entry areas behave this way too (default DKP reward per minute) |
Interesting, I can't remember ever having experienced this, so it might be a platform specific thing that I missed.
| Quote: |
| Loaded up a raid log. I needed to remove the first log checkpoint as it was earlier in the day and spurious to the raid data. Not seeing a delete button, I tried the 'join with next' button, which crashed the program. Reloaded, selected the second log and tried 'join with previous', which also crashed the program. |
I guess it should be allowed to delete the first and last participation log and to add a log to the beginning or end. |
|
Back to top |
|
|
Kolkas
Joined: 13 Apr 2006
Posts: 39
|
| Posted: Thu Jun 29, 2006 4:18 pm Post subject: |
|
|
| Quote: |
| Actually it was supposed to be editeble like the reward intervals, I guess that is a problem too Smile I remember someone telling me that the time column is the only clickable column in the loot table in win32, it is not like that on linux though. I'm not sure why it's like that. |
It wasn't me, but I confirm: in Win32 it acts this way, only time column is clickable for editing loot.
Bye, Kol. |
|
Back to top |
|
|
Lokorin
Site Admin
Joined: 03 Apr 2006
Posts: 697
|
| Posted: Thu Jun 29, 2006 7:09 pm Post subject: |
|
|
I figured that it must be quite hard to test the program when weights are constantly set to 0, therefor I have uploaded a new build with that one thing fixed. It had the same name and is downloaded from the same place. |
|
Back to top |
|
|
Lokorin
Site Admin
Joined: 03 Apr 2006
Posts: 697
|
| Posted: Thu Jun 29, 2006 7:29 pm Post subject: |
|
|
| Quote: |
| If I enter '30' as my loot price, it reformats it to be 0.30. I need to enter '30.0' for it to enter in as I expect. I think I've seen other data entry areas behave this way too (default DKP reward per minute) |
I can't seem to be able to reproduce it under linux, possibly platform specific (someone confirm please). |
|
Back to top |
|
|
impishfae
Joined: 19 Jun 2006
Posts: 125
Location: Australia
|
| Posted: Sun Jul 02, 2006 2:17 pm Post subject: |
|
|
Le maths boog.
When I have 'inverted individual adjustments' set for my reward representation, there's a small bug where an individual will get double dkp.
Raid: Player receives full dkp for the raid's entire period.
Individual adjustment: Player receives negative dkp for each interval they weren't present for.
Individual adjustment: Player also receives positive dkp for each interval they were present for.
This last adjustment is causing a problem, I think.
If 10 = full dkp, and the player lost 6dkp cos they weren't around for the whole raid, then:
Raid: player receives 10 dkp
Individual adjustment: player loses 6dkp (leaving them with a positive total of 10-6=4)
Individual adjustment: player is credited with 4dkp for the interval they were there for (leaving them with a positive total of 8dkp, twice more than they should. 10-6+4=
(Loving the new inverted representation, btw. That's awesome) |
|
Back to top |
|
|
impishfae
Joined: 19 Jun 2006
Posts: 125
Location: Australia
|
| Posted: Sun Jul 02, 2006 2:36 pm Post subject: |
|
|
Le Loot Boog
(Can you tell I tested this out on an actual raid tonight?!)
My loot didn't upload! 
I tried with representing loot as 'events', as 'reward intervals and events', nothing. I assumed they'd show up under the raid as loot won, and as dkp adjustments on players, but I can't seem to find the data anywhere.
My errors.txt is empty. |
|
Back to top |
|
|
impishfae
Joined: 19 Jun 2006
Posts: 125
Location: Australia
|
| Posted: Sun Jul 02, 2006 2:42 pm Post subject: |
|
|
Query: Edit/Prefs/Uploads/Day representation
This is currently set to 'None' on my system and that's the only option available. I'm a-quiver with anticipation at what might be coming here. Are there Cunning Plans (tm) afoot to do cool stuff here, that aren't yet implemented? (Or have I broken something again and I should actually see a second option?! ) |
|
Back to top |
|
|
Lokorin
Site Admin
Joined: 03 Apr 2006
Posts: 697
|
| Posted: Sun Jul 02, 2006 3:00 pm Post subject: |
|
|
The day representation is currently unused but reserved for future ideas.
A loot representation of e.g. "Events" should mean that the loot is only added to event raids if possible. Failing that it should add an additional raid where the loot is added. I will look into this when I get the chance.
Will check and fix the math bug when possible.
And anyone who tried to use the preprocessor: I had forgotten to upload it previously, but it is now available at the default url (http://www.lokorin.com/dkplp/preprocessor).
*edit*
The list of known problems have been updated. |
|
Back to top |
|
|
Lokorin
Site Admin
Joined: 03 Apr 2006
Posts: 697
|
| Posted: Mon Jul 03, 2006 5:34 pm Post subject: |
|
|
| impishfae wrote: |
Le maths boog.
When I have 'inverted individual adjustments' set for my reward representation, there's a small bug where an individual will get double dkp. |
I'm unable to reproduce this, please send me the log and tell me exactly what representation combination you used for all aspects. The same thing with loot.
Combinations I tried with:
Day - None
Reward intervals - Inverted individual adjustments
Event representation - Individual adjustments, individual adjustments and raids
Loot representation - Events
HPB - Raid
The "Allow events with reward equal to 0" option seems broke though.
*edit*
Seeing as I rewrote the DB queries they might be the problem. I'm using MySQL 5.0, I will test with 4.0 in a moment.
*another edit*
I couldn't reproduce it with 4.0 either. |
|
Back to top |
|
|
Lokorin
Site Admin
Joined: 03 Apr 2006
Posts: 697
|
| Posted: Mon Jul 03, 2006 7:41 pm Post subject: |
|
|
| Kolkas wrote: |
| Quote: |
| Actually it was supposed to be editeble like the reward intervals, I guess that is a problem too Smile I remember someone telling me that the time column is the only clickable column in the loot table in win32, it is not like that on linux though. I'm not sure why it's like that. |
It wasn't me, but I confirm: in Win32 it acts this way, only time column is clickable for editing loot.
Bye, Kol. |
It *should* be fixed now, but I can't test it myself. So ut would be helpful if someone with subversion set up on Windows could check out the latest revision and test that (and then report whether it is fixed ot not). The problem was that I had forgotten to flip an option that allows selecting any part of the column, apparently turning that option off had no effect on Linux. |
|
Back to top |
|
|
impishfae
Joined: 19 Jun 2006
Posts: 125
Location: Australia
|
| Posted: Tue Jul 04, 2006 1:27 am Post subject: |
|
|
Have svn, will test...
Can confirm that any column is now clickable in the loot table: nice work! |
|
Back to top |
|
|
impishfae
Joined: 19 Jun 2006
Posts: 125
Location: Australia
|
| Posted: Tue Jul 04, 2006 1:52 am Post subject: |
|
|
| Lokorin wrote: |
| impishfae wrote: |
Le maths boog.
When I have 'inverted individual adjustments' set for my reward representation, there's a small bug where an individual will get double dkp. |
I'm unable to reproduce this, please send me the log and tell me exactly what representation combination you used for all aspects. The same thing with loot.
|
Ok, my bad. Too much old testing data cluttering my site (I need to write a quick 'reset db' command or something) and I misread what I was seeing. There is no maths boog!
Loot bug
Log file attached. I have tried with Loot set to Events, Reward Intervals, and Reward Intervals And Events. Reward interval representation has been on individual adjustment, compressed individual or inverted. Event representation has been on individual adjustment and compressed individual adjustment. HPB on Individual adjustment.
I've tried checking and unchecking 'upload loot items with price equal to 0'.
Let me know if you want the url to my test site to see the spam in full glory. |
|
Back to top |
|
|
impishfae
Joined: 19 Jun 2006
Posts: 125
Location: Australia
|
| Posted: Wed Jul 05, 2006 7:18 am Post subject: |
|
|
1.4.0 enquiry: approximative join/leave vs exact join/leave
I'm not sure what the difference is between these two modes? (If 'exact' is like 'approximative' only ... better/more accurate, would anyone still want to use approximative?) I'm assuming that approximative is the same as the old join/leave mode and the exact is the new and improved one... |
|
Back to top |
|
|
|
|
