|
|
Author |
Message |
impishfae
Joined: 19 Jun 2006
Posts: 125
Location: Australia
|
 Posted: Sat Jul 08, 2006 9:37 am Post subject: |
|
|
| Quote: |
| Quote: |
Loot Bug
The first one showed up inside dkprpc.php line 798. I ended up swapping the line for one saying $possibleRaidIndicies[] = $multipurposeRaid because by definition, at that point, $possibleRaidIndices was empty, and $raids had to contain $multipurposeRaid (thanks to line 764) |
$possibleRaidIndicies should contain the keys of the possible raids as they appear in $raids (array_search returns the key, not the value), hence adding an object might give unexpected results. |
 ok, so once I ditched the forehead slap mistake...
array_search was still barfing up a null pointer exception. Further research showed that array_search can't handle having objects as the needle to search within the haystack. (found buried in the depths of the comments of array_search in php manual)
So if I replace the line of 798 from
| Code: |
$possibleRaidIndicies[] = array_search($multipurposeRaid, $raids);
|
to
| Code: |
foreach($raids as $key => $val) {
if ($multipurposeRaid === $val) {
$possibleRaidIndicies[] = $key;
}
}
|
it all seemed a bit happier. No more NPE, data created on the server, happy daffodils. Tested with compressed rewards, inverted rewards, compressed events, compressed events.
(No, I have no idea why this works. It was a 'suck it and see' approach based off the comments on the forum  )
| Quote: |
| Quote: |
Raid name not being set
|
This is a bit in limbo at the moment and not meant to work. The idea is that sometime before the beta the note format will be allowed to contain $3 which will be translated to the raid name. Hence if one wants the note "19:00 - 19:21: Foozone" then the format would be "$1 - $2: $3". At the same time the events are supposed to get note formats like the ones used for reward intervals (with use global event note options etc). They will be allowed to contain $1: The time of the event and $2: The name of the event. This will be done sometime before the beta. |
I think I've gotten confused, so I'll go back to basics...
How is the name of the summary raid set, assuming you've got raid batching switched on? I had assumed it came from the zone name of the first reward interval. At the moment it's taking on the date.
I had also assumed it was independent of the interval and event notes (with the $1, etc substitution). I thought the interval notes were the names of the individual adjustment lines.
| Quote: |
| Quote: |
Feature requests
Zone name on adjustments
Is it possible to enforce the inclusion of the raid name on the individual adjustments for intervals and events? (whether individual, compressed or inverted) |
I guess all the notes could be pooled together, kind of like the compressed events are currently handled (their compressed note appears as "Doomright Vakrizt , Pardass Predd , The Slavering Alzid , Doom Thingies x 3 , Uustalastus Xiterrax"). |
I've been using compressed reward intervals with raid batching only. At which point the reward interval notes are just a bunch of timestamps: concatenating them all together doesn't add too much (given you already have the total time already). What I'm hankering for is a means to tie that individual adjustment back up to the raid it came from, by prepending the raid name.
It's possible this is another instance of me getting my wires crossed, not understanding where the overall raid name comes from. |
|
Back to top |
|
 |
Lokorin
Site Admin
Joined: 03 Apr 2006
Posts: 697
|
| Posted: Sat Jul 08, 2006 10:10 am Post subject: |
|
|
| impishfae wrote: |
| it all seemed a bit happier. No more NPE, data created on the server, happy daffodils. Tested with compressed rewards, inverted rewards, compressed events, compressed events. |
Yay 
| Quote: |
I think I've gotten confused, so I'll go back to basics...
How is the name of the summary raid set, assuming you've got raid batching switched on? I had assumed it came from the zone name of the first reward interval. At the moment it's taking on the date.
I had also assumed it was independent of the interval and event notes (with the $1, etc substitution). I thought the interval notes were the names of the individual adjustment lines. |
I misread the first time around, I was talking about raid notes, not the EQDKP event name. Setting the multipurpose raid name to the first supplied zone name if one exists should not be a problem, ignore what I was saying about notes.
| Quote: |
| I've been using compressed reward intervals with raid batching only. At which point the reward interval notes are just a bunch of timestamps: concatenating them all together doesn't add too much (given you already have the total time already). What I'm hankering for is a means to tie that individual adjustment back up to the raid it came from, by prepending the raid name. |
Now I understand, will do. I also noticed some errors in the code that were introduced in one of my previous changes which makes it so that the raid name is not used as event name when it should be, I will try to fix those things. |
|
Back to top |
|
|
Lokorin
Site Admin
Joined: 03 Apr 2006
Posts: 697
|
| Posted: Sat Jul 08, 2006 11:45 am Post subject: |
|
|
The plugin will now select an EQDKP event name for the whole day. It uses the first raid name if possible, otherwise the first event name is used and failing that the date is used.
That name is then prepended to everything related to the day bar reward intervals and events represented as raids.
*edit*
Attaching the files while svn is down. |
|
Back to top |
|
|
impishfae
Joined: 19 Jun 2006
Posts: 125
Location: Australia
|
| Posted: Sat Jul 08, 2006 2:54 pm Post subject: |
|
|
Yippeeeee! Release the happy dancing pirate monkeys!
Awesome. It all works. There's loot, there's a raid name, there's a raid name on my adjustments, there's no more null pointer exceptions. Beta feels a lot closer now. (And I can go back to writing up help files rather than testing )
Nice work, Lokorin. We who are on the other side of the world, salute you! |
|
Back to top |
|
|
Lokorin
Site Admin
Joined: 03 Apr 2006
Posts: 697
|
| Posted: Sat Jul 08, 2006 4:58 pm Post subject: |
|
|
Great
| impishfae wrote: |
| Code: |
$possibleRaidIndicies[] = array_search($multipurposeRaid, $raids);
|
to
| Code: |
foreach($raids as $key => $val) {
if ($multipurposeRaid === $val) {
$possibleRaidIndicies[] = $key;
}
}
|
|
I noticed that the current revision does not contain your fix. Did it work without the fix or should one of us commit that too? |
|
Back to top |
|
|
impishfae
Joined: 19 Jun 2006
Posts: 125
Location: Australia
|
| Posted: Sat Jul 08, 2006 11:15 pm Post subject: |
|
|
The latest latest revision should have the fix. I was raiding last night (uh, Sat morning, US EST time) during our last round of exchanges, so didn't commit it until after we had done with the killing and the dying.
Didn't want to commit in haste lest I mess something up. |
|
Back to top |
|
|
impishfae
Joined: 19 Jun 2006
Posts: 125
Location: Australia
|
| Posted: Sun Jul 09, 2006 10:00 pm Post subject: |
|
|
The 'split' command doesn't seem to be working for me still...
I have two attendance logs (on classic mode) which gives me one interval with two participant lists.
When on the first participant tab list, with the interval listing as 20:05 to 22:%8, I click split. It asks me to put in a new time (between the original start/finish times). I enter 20:15:00. Hit 'ok'. Nothing happens. No error in the error file either.
Join with next/previous doesn't work either (but then, I'm sorta not expecting it to since there is only one interval and doing a join would leave me with nothing!) |
|
Back to top |
|
|
Lokorin
Site Admin
Joined: 03 Apr 2006
Posts: 697
|
| Posted: Mon Jul 10, 2006 6:07 am Post subject: |
|
|
That sounds strange, it works fine for me. The join operation should also have worked since there were two participation intervals (if I understood you correctly). The participation has no effect on the number of reward intervals, only on the participation. You could have 10 reward intervals backed by just one participation interval, all reward intervals would have the same participation but could be given different bonuses etc.
I think I should create a picture of how that works sometime. Basically the participation intervals are a solid foundation layer upon which fragmented reward intervals and events may rest. |
|
Back to top |
|
|
impishfae
Joined: 19 Jun 2006
Posts: 125
Location: Australia
|
| Posted: Mon Jul 10, 2006 6:42 am Post subject: |
|
|
Somewhere in this thread I asked if the config dialog could be made modal. While we're at it, if the 'select day' dialog could also go modal too, that'd be awesome. Stop me from reparsing the same file over again. |
|
Back to top |
|
|
impishfae
Joined: 19 Jun 2006
Posts: 125
Location: Australia
|
| Posted: Sat Jul 15, 2006 1:42 am Post subject: |
|
|
The latest drop of the code has the split/join on reward intervals working again for me.
Now I'm a bit confused on how the code works out the participants for each interval.
If I have 3 participants (A, B, C) in interval 1:00 to 2:00
I split the interval 1:00 to 1:30, 1:31 to 2:00
Both intervals have participants A, B, C
Then in interval 1:00 to 1:30 I remove participant B (since that was the reason I split it in the first place)
So 1:00 to 1:30 has A, C. 1:31 to 2:00 has A, B, C
Then if I've had a moment of craziness and decide the interval split was wrong after all, and I select 1:00 to 1:30 and do a 'join with next', I have interval 1:00 to 2:00 with participants A, C.
Does the split/join code just take the intersection of the participants from each interval (ie: only the set of names that were present in both intervals)? Or is there something more cunning at work? (the set of members that were present for a majority of time across the entire interval?) |
|
Back to top |
|
|
Lokorin
Site Admin
Joined: 03 Apr 2006
Posts: 697
|
| Posted: Sat Jul 15, 2006 10:07 am Post subject: |
|
|
It uses the intersection. I figured that it would be best to guarantee that if someone is present during a participation interval 1:00 to 2:00 then that person was present during the whole time. If it would only have meant that the person was present during a majority of the time then things could get confusing when there for instance is an event at 1:01, the person might be recorded as being present during that event without actually being there. |
|
Back to top |
|
|
impishfae
Joined: 19 Jun 2006
Posts: 125
Location: Australia
|
| Posted: Sun Jul 16, 2006 2:09 am Post subject: |
|
|
The add button on the reward intervals tab in the reward situations panel need a 'cancel' as well as a 'done' button. At the moment if you hit it by accident (or as I did, in a fit of 'ooo! let's try this button out!'), you have to add a new reward interval before the dialog box goes away.
Also got a bit confused... I have six participation records with various numbers of participants in each one.
The system is only showing 3 reward intervals: the first three. The last three aren't displaying.
Not sure if this is a bug or if I have a configuration option set which is making the system disregard the other intervals? |
|
Back to top |
|
|
Lokorin
Site Admin
Joined: 03 Apr 2006
Posts: 697
|
| Posted: Sun Jul 16, 2006 8:45 am Post subject: |
|
|
The reward intervals are not automatically dependent on the participation intervals, that depends on what parse mode you're running. If you're running Classic mode then there should be more reward intervals than that, what times do the participation intervals and reward intervals span? |
|
Back to top |
|
|
impishfae
Joined: 19 Jun 2006
Posts: 125
Location: Australia
|
| Posted: Sun Jul 16, 2006 9:44 am Post subject: |
|
|
Ironically, I only noticed while typing up the docco on the screens. Take a look at the screenshots I committed into the help a moment ago: they'll show you the intervals and participation sets it came up with. (Names blurred out to protect the guilty!)
Running classic mode, no zero-sum.
Holler if you want the log of gargantuanness. |
|
Back to top |
|
|
Lokorin
Site Admin
Joined: 03 Apr 2006
Posts: 697
|
| Posted: Sun Jul 16, 2006 11:26 am Post subject: |
|
|
That certainly doesn't look correct to me, please send me the log. |
|
Back to top |
|
|
|
